Add test summary #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix xcpretty_naming for xcresult * Add test result object hierarchy * Refactored group and name parsing function # Conflicts: # Gemfile.lock # lib/trainer/test_parser.rb
ketenshi
reviewed
Jul 7, 2021
fastlane-plugin-trainer/lib/fastlane/plugin/trainer/actions/trainer_action.rb
Show resolved
Hide resolved
ketenshi
approved these changes
Jul 7, 2021
|
Any plan on merging these fixes in the original repo? |
I didn’t open a PR there because I merged an open PR from the original repo that was open for two years and added some stuff to it here. |
|
But it fixes the missing failed tests, right? I'm wondering if the original repo can take advantage of them. |
|
@kikettas yeah but it doesn’t look like the original repo is maintained. |
|
I see. It's a pity then, as it's the probably the best extracting tool for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds changes from fastlane-community#40 and adds the total number of tests and failures to environment variables.
Also fixes the format of the junit file to include line number