fix: wrong duplicates (#95)

.gitignore

@@ -1,3 +1,4 @@
 node_modules
+!__tests__/packages/**/node_modules
 .DS_Store
 .idea/

__tests__/__snapshots__/duplicates.test.js.snap

@@ -0,0 +1,22 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`Running the programmatic interface return expected duplicates in json 1`] = `
+Object {
+  "npmPackages": Object {
+    "b": Object {
+      "duplicates": Array [
+        "1.0.2",
+      ],
+      "installed": "1.0.0",
+      "wanted": "1.0.0",
+    },
+  },
+}
+`;
+
+exports[`Running the programmatic interface return expected duplicates in yaml 1`] = `
+"
+  npmPackages:
+    b: 1.0.0 => 1.0.0 (1.0.2)
+"
+`;

__tests__/duplicates.test.js

@@ -0,0 +1,26 @@
+const envinfo = require('../src/envinfo');
+const path = require('path');
+
+describe('Running the programmatic interface', () => {
+  test('return expected duplicates in json', async () => {
+    const cwd = process.cwd();
+    process.chdir(path.join(__dirname, 'packages/test-duplicates'));
+    try {
+      const data = await envinfo.run({ npmPackages: ['b'] }, { duplicates: true, json: true });
+      expect(JSON.parse(data)).toMatchSnapshot();
+    } finally {
+      process.chdir(cwd);
+    }
+  });
+
+  test('return expected duplicates in yaml', async () => {
+    const cwd = process.cwd();
+    process.chdir(path.join(__dirname, 'packages/test-duplicates'));
+    try {
+      const data = await envinfo.run({ npmPackages: ['b'] }, { duplicates: true });
+      expect(data).toMatchSnapshot();
+    } finally {
+      process.chdir(cwd);
+    }
+  });
+});

__tests__/packages/test-duplicates/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "test-duplicates",
+  "version": "1.0.0",
+  "dependencies": {
+    "a": "1.0.0",
+    "b": "1.0.0"
+  }
+}

src/packages.js

@@ -81,26 +81,33 @@ function getnpmPackages(packages, options) {
         const paths = result[0];
         const files = result[1];
 
-        return files.reduce((acc, d, idx) => {
+        const versions = files.reduce((acc, d, idx) => {
           // if the file is a test stub, or doesn't have a name, ignore it.
           if (!d || !d.name) return acc;
           // create object if its not already created
           if (!acc[d.name]) acc[d.name] = {};
-          // set duplicates if flag set, if version not already there, && !== installed
+          // set duplicates if flag set, if version not already there
           if (options.duplicates) {
-            if (acc[d.name].installed && acc[d.name].installed !== d.version) {
-              utils.uniq(
-                (acc[d.name].duplicates = (acc[d.name].duplicates || []).concat(d.version))
-              );
-            }
+            acc[d.name].duplicates = utils.uniq((acc[d.name].duplicates || []).concat(d.version));
           }
           // set the installed version, if its installed top level
           if ((paths[idx].match(/node_modules/g) || []).length === 1)
             acc[d.name].installed = d.version;
-          // if it is a top level dependency, get the wanted version
-          if (tld[d.name]) acc[d.name].wanted = tld[d.name];
           return acc;
         }, {});
+
+        Object.keys(versions).forEach(name => {
+          // update duplicates, only !== installed
+          if (versions[name].duplicates && versions[name].installed) {
+            versions[name].duplicates = versions[name].duplicates.filter(
+              v => v !== versions[name].installed
+            );
+          }
+          // if it is a top level dependency, get the wanted version
+          if (tld[name]) versions[name].wanted = tld[name];
+        });
+
+        return versions;
       })
       .then(versions => {
         if (options.showNotFound && Array.isArray(packages)) {