[civiremote_entity] Rebuild form in case of error #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontub
force-pushed
the
stay-on-form-page-on-error
branch
from
3115d80
to
d1e46d8
Compare
jensschuppe
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Will the destination parameter be lost entirely or just "postponed" to the next submit?
Wondering whether we should instead rebuild the form (as failed validation does) - this would avoid a redirect to the destination as well and keep the form instance alive (see Drupal Form API Workflow).
dontub
force-pushed
the
stay-on-form-page-on-error
branch
from
d1e46d8
to
8c81a5a
Compare
dontub
changed the title
|
You're right, rebuilding is the better approach here so I changed that. |
Previously on error a redirect to the destination (URL parameter) was executed, if given. Otherwise, a redirect to the form page was executed. Now in both cases the form is rebuild (so the entered values are kept).
dontub
force-pushed
the
stay-on-form-page-on-error
branch
from
8c81a5a
to
505f727
Compare
dontub
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on error a redirect to the destination (URL parameter) was executed, if given. Otherwise, a redirect to the form page was executed. Now in both cases the form is rebuild (so the entered values are kept).