Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use form ID depending on route context #24

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

jensschuppe
Copy link
Collaborator

Fixes a regression introduced with #19. Instead of using context-dependent form builders, the ReigsterForm class was always used. This PR passes the route context to the method that determines the form ID/form builder class.

@FeyP you might want to have a look at this, although I'll merge this right away.

@jensschuppe jensschuppe added bug Something isn't working status:needs review Code needs review and testing labels Feb 21, 2024
@jensschuppe jensschuppe added this to the 1.1.x milestone Feb 21, 2024
@jensschuppe jensschuppe merged commit c411749 into 1.1.x Feb 21, 2024
14 checks passed
@jensschuppe jensschuppe deleted the formBuilderContext branch February 21, 2024 13:37
@jensschuppe jensschuppe added status:fixed The issue has been resolved (usually by committing/merging code) and removed status:needs review Code needs review and testing labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:fixed The issue has been resolved (usually by committing/merging code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant