Fixing the issue with getting different results on mac m1s #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adelhpour
commented
Jun 30, 2024
adelhpour
commented
- if the PresimulationProgramDecorator solve function fails, we now throw a CoreException
…ow a CoreException.
…changes they lead to an exception and the steady state is not achieved anymore
…he new changes they lead to an exception and the steady state is not reached anymore
… is achieved in PresimulationProgramDecorator solve function.
adelhpour
changed the title
…which no steady state is reached.
…pdated (the issue with nleq2 is addressed in the new version of libroadrunner-deps)
…o that it considers the condition in which no steady state is reached.
|
Looks good to me! |
luciansmith
deleted the
fix-the-issue-with-getting-different-results-on-mac-m1s
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.