forked from AndySomogyi/sbmlsolver
-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add additional doc for different SelectionTypes
- Loading branch information
Kiri Choi
committed
Sep 30, 2017
1 parent
73e97d6
commit 1554ef3
Showing
1 changed file
with
143 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1554ef3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing tests are the RK4 & RK45 integrators. They seem to fail randomly. @kirichoi do you know what might be causing this?
1554ef3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fyi I restarted the build to see if they're random.
1554ef3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I did fixed this issue as part of pull request #416 which haven't merged yet. In particular, commit 300de2d fixes it. That particular pull request got all over the place with different branches actually. What would you like me to do? I can selectively push that fix and re-issue a new pull request for fixing issue #411.
1554ef3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just merge your PR 😄
1554ef3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It failed and fixed again. Not sure what's going on anymore 😨
1554ef3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the SBML tests is designed to fail spuriously once in a while. I wouldn't worry about it.