Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make name parameter kwarg #142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aturker-synnada
Copy link
Collaborator

Description

Closes #141

What is Changed

  • Name parameter became kwarg in all primitives and models.

Checklist:

  • Tests that cover the code added.
  • Corresponding changes documented.
  • All tests passed.
  • The code linted and styled (pre-commit run --all-files has passed).

@aturker-synnada aturker-synnada changed the title name paramter become kwarg chore: Make name parameter kwarg Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (941bb50) to head (733e484).

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files          61       61           
  Lines       15359    15359           
=======================================
  Hits        13637    13637           
  Misses       1722     1722           
Files with missing lines Coverage Δ
mithril/framework/logical/essential_primitives.py 99.50% <100.00%> (ø)
mithril/framework/logical/model.py 97.10% <100.00%> (ø)
mithril/framework/logical/primitive.py 95.72% <ø> (ø)
mithril/models/models.py 88.68% <ø> (ø)
mithril/models/primitives.py 97.23% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] Make name kwarg
3 participants