Support constraints in physical query planning #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokselk
changed the title
gokselk
force-pushed
the
feature/physical-planner-functional-dependence
branch
from
9f3b41c to
a680f87
Compare
gokselk
force-pushed
the
feature/physical-planner-functional-dependence
branch
2 times, most recently
from
42201f0 to
319f13f
Compare
gokselk
changed the title
gokselk
force-pushed
the
feature/physical-planner-functional-dependence
branch
from
319f13f to
82361a7
Compare
berkaysynnada
approved these changes
Jan 6, 2025
| @@ -254,10 +266,27 @@ impl FileScanConfig { | |||
| self.file_schema.metadata().clone(), | |||
| )); | |||
|
|
|||
| let proj_indices = match &self.projection { | |||
| Some(proj) => proj.to_vec(), | |||
| None => (0..(self.file_schema.fields().len() | |||
There was a problem hiding this comment.
This check match &self.projection has been done above, And also another similar check if self.projection.is_none() exists. Perhaps we can refactor this function, starting with a match pattern on self.projection, wdyt?
There was a problem hiding this comment.
Took a different approach, deduplicated the code in 46b860f. Please let me know if this works as well.
gokselk
force-pushed
the
feature/physical-planner-functional-dependence
branch
from
940c330 to
05384e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?