Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NoMixedCallableRule, as handled by PHPStan - https://phpstan.org/writing-php-code/phpdoc-types\#callables #80

Merged
merged 2 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/code-complexity-rules.neon
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
rules:
- Symplify\PHPStanRules\Rules\Explicit\NoMixedCallableRule
- Symplify\PHPStanRules\Rules\Explicit\NoMixedPropertyFetcherRule
- Symplify\PHPStanRules\Rules\Explicit\NoMixedMethodCallerRule
- Symplify\PHPStanRules\Rules\PHPUnit\NoRightPHPUnitAssertScalarRule
Expand Down
1 change: 0 additions & 1 deletion config/services/services.neon
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ services:
- Symplify\PHPStanRules\PhpDocParser\SimplePhpDocParser
- Symplify\PHPStanRules\Reflection\ReflectionParser
- Symplify\PHPStanRules\Matcher\ArrayStringAndFnMatcher
- Symplify\PHPStanRules\TypeResolver\ClassMethodReturnTypeResolver
- Symplify\PHPStanRules\NodeFinder\TypeAwareNodeFinder
- Symplify\PHPStanRules\PhpDoc\SeePhpDocTagNodesFinder
- Symplify\PHPStanRules\TypeAnalyzer\ContainsTypeAnalyser
Expand Down
5 changes: 0 additions & 5 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ parameters:
- '#Class Symplify\\PHPStanRules\\(.*?)Rule implements generic interface PHPStan\\Rules\\Rule but does not specify its types\: TNodeType#'
- '#Method (.*?)::getCollectors\(\) return type with generic interface PHPStan\\Collectors\\Collector does not specify its types\: TNodeType, TValue#'

# invalid PHPStan type - it alwasy requires 2 types to traverse with callable
-
message: '#Callable callable\(PHPStan\\Type\\Type\)\: PHPStan\\Type\\Type invoked with 2 parameters, 1 required#'
path: src/Rules/Explicit/NoMixedCallableRule.php

- '#Parameter \#1 \$values of method Symplify\\PHPStanRules\\Rules\\Enum\\RequireUniqueEnumConstantRule\:\:filterDuplicatedValues\(\) expects array<int\|string>, array<bool\|float\|int\|string> given#'

- '#Class PHP_CodeSniffer\\Sniffs\\Sniff not found#'
Expand Down
102 changes: 0 additions & 102 deletions src/Rules/Explicit/NoMixedCallableRule.php

This file was deleted.

35 changes: 0 additions & 35 deletions src/TypeResolver/ClassMethodReturnTypeResolver.php

This file was deleted.

This file was deleted.

13 changes: 0 additions & 13 deletions tests/Rules/Explicit/NoMixedCallableRule/Fixture/MixedCallable.php

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.