Remove NoShortNameRule, as devs are educated and not a thing anymore (#…

…127)
symplify · May 26, 2024 · 9213f3c · 9213f3c
1 parent af09e51
commit 9213f3c
Show file tree

Hide file tree

Showing 11 changed files with 1 addition and 326 deletions.
diff --git a/config/configurable-rules.neon b/config/configurable-rules.neon
@@ -5,12 +5,6 @@ services:
         arguments:
             toleratedNestingLevel: 2
 
-    -
-        class: Symplify\PHPStanRules\ObjectCalisthenics\Rules\NoShortNameRule
-        tags: [phpstan.rules.rule]
-        arguments:
-            minNameLength: 2
-
     -
         class: Symplify\PHPStanRules\Rules\ForbiddenNodeRule
         tags: [phpstan.rules.rule]

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 40 Rules Overview
+# 38 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -994,45 +994,6 @@ final class SomeClass
 
 <br>
 
-## NoShortNameRule
-
-Do not name "%s", shorter than %d chars
-
-:wrench: **configure it!**
-
-- class: [`Symplify\PHPStanRules\ObjectCalisthenics\Rules\NoShortNameRule`](../src/ObjectCalisthenics/Rules/NoShortNameRule.php)
-
-```yaml
-services:
-    -
-        class: Symplify\PHPStanRules\ObjectCalisthenics\Rules\NoShortNameRule
-        tags: [phpstan.rules.rule]
-        arguments:
-            minNameLength: 3
-```
-
-↓
-
-```php
-function is()
-{
-}
-```
-
-:x:
-
-<br>
-
-```php
-function isClass()
-{
-}
-```
-
-:+1:
-
-<br>
-
 ## NoTestMocksRule
 
 Mocking "%s" class is forbidden. Use direct/anonymous class instead for better static analysis

diff --git a/src/ObjectCalisthenics/Rules/NoShortNameRule.php b/src/ObjectCalisthenics/Rules/NoShortNameRule.php
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/AllowD.php b/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/AllowD.php
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/ShortAssignParameter.php b/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/ShortAssignParameter.php
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/ShortClosureParam.php b/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/ShortClosureParam.php
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/ShortNamingClass.php b/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/ShortNamingClass.php
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/ShortParam.php b/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/ShortParam.php
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/SkipId.php b/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/SkipId.php
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/NoShortNameRuleTest.php b/tests/ObjectCalisthenics/Rules/NoShortNameRule/NoShortNameRuleTest.php
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/config/configured_rule.neon b/tests/ObjectCalisthenics/Rules/NoShortNameRule/config/configured_rule.neon