Remove CheckSprintfMatchingTypesRule as can be on purpose

symplify · Aug 22, 2023 · 78b72f7 · 78b72f7
1 parent f9f352c
commit 78b72f7
Show file tree

Hide file tree

Showing 12 changed files with 1 addition and 378 deletions.
diff --git a/config/static-rules.neon b/config/static-rules.neon
@@ -1,7 +1,5 @@
 rules:
     - Symplify\PHPStanRules\Rules\NoProtectedClassElementRule
-
-    - Symplify\PHPStanRules\Rules\Missing\CheckSprintfMatchingTypesRule
     - Symplify\PHPStanRules\Rules\ForbiddenExtendOfNonAbstractClassRule
 
     # domain

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 58 Rules Overview
+# 56 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -179,28 +179,6 @@ interface ProductRepositoryInterface
 
 <br>
 
-## CheckSprintfMatchingTypesRule
-
-`sprintf()` call mask type at index [%d] expects type "%s", but "%s" given
-
-- class: [`Symplify\PHPStanRules\Rules\Missing\CheckSprintfMatchingTypesRule`](../src/Rules/Missing/CheckSprintfMatchingTypesRule.php)
-
-```php
-echo sprintf('My name is %s and I have %d children', 10, 'Tomas');
-```
-
-:x:
-
-<br>
-
-```php
-echo sprintf('My name is %s and I have %d children', 'Tomas', 10);
-```
-
-:+1:
-
-<br>
-
 ## CheckTypehintCallerTypeRule
 
 Parameter %d should use "%s" type as the only type passed to this method
@@ -2140,55 +2118,6 @@ class SomeClass extends Rule
 
 <br>
 
-## TwigPublicCallableExistsRule
-
-The callable method [$this, "%s"] was not found
-
-- class: [`Symplify\PHPStanRules\Symfony\Rules\TwigPublicCallableExistsRule`](../packages/Symfony/Rules/TwigPublicCallableExistsRule.php)
-
-```php
-use Twig\Extension\AbstractExtension;
-use Twig_SimpleFunction;
-
-final class TwigExtensionWithMissingCallable extends AbstractExtension
-{
-    public function getFunctions()
-    {
-        return [
-            new Twig_SimpleFunction('someFunctionName', [$this, 'someMethod']),
-        ];
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-use Twig\Extension\AbstractExtension;
-use Twig_SimpleFunction;
-
-final class TwigExtensionWithMissingCallable extends AbstractExtension
-{
-    public function getFunctions()
-    {
-        return [
-            new Twig_SimpleFunction('someFunctionName', [$this, 'someMethod']),
-        ];
-    }
-
-    public function someMethod()
-    {
-        // ...
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ## UppercaseConstantRule
 
 Constant "%s" must be uppercase

diff --git a/src/Rules/Missing/CheckSprintfMatchingTypesRule.php b/src/Rules/Missing/CheckSprintfMatchingTypesRule.php
diff --git a/tests/Rules/Missing/CheckSprintfMatchingTypesRule/CheckSprintfMatchingTypesRuleTest.php b/tests/Rules/Missing/CheckSprintfMatchingTypesRule/CheckSprintfMatchingTypesRuleTest.php
diff --git a/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/MissMatchSprintf.php b/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/MissMatchSprintf.php
diff --git a/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/SkipCorrectForeachKey.php b/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/SkipCorrectForeachKey.php
diff --git a/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/SkipCorrectSprintf.php b/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/SkipCorrectSprintf.php
diff --git a/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/SkipErrorType.php b/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/SkipErrorType.php
diff --git a/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/SkipToString.php b/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/SkipToString.php
diff --git a/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/SkipValidTernary.php b/tests/Rules/Missing/CheckSprintfMatchingTypesRule/Fixture/SkipValidTernary.php