Skip Iterator in NoArrayAccessOnObjectRule

symplify · Aug 22, 2023 · 2f6df68 · 2f6df68
1 parent 71d5cee
commit 2f6df68
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/src/Rules/NoArrayAccessOnObjectRule.php b/src/Rules/NoArrayAccessOnObjectRule.php
@@ -26,7 +26,7 @@ final class NoArrayAccessOnObjectRule implements Rule, DocumentedRuleInterface
     /**
      * @var array<class-string>
      */
-    private const ALLOWED_CLASSES = ['SplFixedArray', 'SimpleXMLElement'];
+    private const ALLOWED_CLASSES = ['SplFixedArray', 'SimpleXMLElement', 'Iterator'];
 
     public function __construct(
         private readonly ArrayStringAndFnMatcher $arrayStringAndFnMatcher

diff --git a/tests/Rules/NoArrayAccessOnObjectRule/Fixture/SkipIterator.php b/tests/Rules/NoArrayAccessOnObjectRule/Fixture/SkipIterator.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\NoArrayAccessOnObjectRule\Fixture;
+
+final class SkipIterator
+{
+    public function run()
+    {
+        $iterator = new class extends \Iterator {};
+
+        return $iterator[0];
+    }
+}
diff --git a/tests/Rules/NoArrayAccessOnObjectRule/NoArrayAccessOnObjectRuleTest.php b/tests/Rules/NoArrayAccessOnObjectRule/NoArrayAccessOnObjectRuleTest.php
@@ -26,6 +26,7 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/ArrayAccessOnObject.php', [[NoArrayAccessOnObjectRule::ERROR_MESSAGE, 14]]];
         yield [__DIR__ . '/Fixture/ArrayAccessOnNestedObject.php', [[NoArrayAccessOnObjectRule::ERROR_MESSAGE, 14]]];
 
+        yield [__DIR__ . '/Fixture/SkipIterator.php', []];
         yield [__DIR__ . '/Fixture/SkipOnArray.php', []];
         yield [__DIR__ . '/Fixture/SkipSplFixedArray.php', []];
         yield [__DIR__ . '/Fixture/SkipXml.php', []];