[Workflow] Use a strict comparison when retrieving raw markin in Mark…

…ingStore
symfony · Apr 7, 2020 · b46e9ae · b46e9ae
1 parent 5e9ac66
commit b46e9ae
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/MarkingStore/SingleStateMarkingStore.php b/MarkingStore/SingleStateMarkingStore.php
@@ -44,7 +44,7 @@ public function getMarking($subject)
     {
         $placeName = $this->propertyAccessor->getValue($subject, $this->property);
 
-        if (!$placeName) {
+        if (null === $placeName) {
             return new Marking();
         }
 

diff --git a/Tests/MarkingStore/SingleStateMarkingStoreTest.php b/Tests/MarkingStore/SingleStateMarkingStoreTest.php
@@ -30,4 +30,17 @@ public function testGetSetMarking()
 
         $this->assertEquals($marking, $marking2);
     }
+
+    public function testAlmostEmptyPlaceName()
+    {
+        $subject = new \stdClass();
+        $subject->myMarks = 0;
+
+        $markingStore = new SingleStateMarkingStore('myMarks');
+
+        $marking = $markingStore->getMarking($subject);
+
+        $this->assertInstanceOf(Marking::class, $marking);
+        $this->assertCount(1, $marking->getPlaces());
+    }
 }