Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] use dedicated cache pool #2410

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

IndraGunawan
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

based on @stof comment on EasyAdminBundle repository EasyCorp/EasyAdminBundle#6507 (comment)

you should probably create a dedicated cache pool inheriting its configuration from cache.system instead of using cache.system directly. this is how core Symfony components work (allowing them to avoid having to care about conflicting keys between the caches of different component, as the key only needs to be unique inside the cache pool)

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Nov 28, 2024
@IndraGunawan IndraGunawan changed the title use dedicated cache pool for ux-icons [Icons] use dedicated cache pool Nov 28, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 28, 2024
@Kocal
Copy link
Member

Kocal commented Nov 29, 2024

Thank you @IndraGunawan.

@Kocal Kocal merged commit 885495a into symfony:2.x Nov 29, 2024
7 checks passed
@IndraGunawan IndraGunawan deleted the dedicated-cache-pool branch November 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants