Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier] Enable auto-configuration for the GoIP bridge #1326

Merged

Conversation

ahmedghanem00
Copy link
Contributor

Q A
License MIT
Doc issue/PR

This has been forgotten to be set/enabled when the recipe was introduced for the first time.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) July 8, 2024 17:13
Copy link

github-actions bot commented Jul 8, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1326/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1326/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/go-ip-notifier:^6.4'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@ahmedghanem00 ahmedghanem00 changed the title [Notifier] Enable auto-configuration for the GoIP bridge in notifier.yaml [Notifier] Enable auto-configuration for the GoIP bridge Jul 8, 2024
@ahmedghanem00
Copy link
Contributor Author

@OskarStark Thanks for the review. It's notable also that since this package was renamed last year from the old name goip-notifier to the new name go-ip-notifier, the old name is still present on Packagist here ​​and the package can only be downloaded/installed via this old name.

This also makes the package recipe here not work correctly because Flex assumes the new name 😞. So, someone with proper access to Packagist may do the renaming there as well? (abandon the package with the old name and then re-publish it again under the new name)

@OskarStark
Copy link
Contributor

friendly ping @fabpot

@symfony-recipes-bot symfony-recipes-bot merged commit 0bdf42c into symfony:main Jul 9, 2024
1 of 2 checks passed
@ahmedghanem00 ahmedghanem00 deleted the notifier-goip-patch-1 branch July 9, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants