-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
factory-method="getMetadataFactory" | ||
/> | ||
class="%cmf_routing_auto.metadata.factory.class%"> | ||
<factory service="cmf_routing_auto.metadata.factory.builder" method="getMetadataFactory" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm .. this is 2.6 only, should I revert this..
f59d0a3
to
2897c54
Compare
Failing on lowest dependencies because of deprecations: https://travis-ci.org/symfony-cmf/RoutingAutoBundle/jobs/97946914 /cc @wouterj |
@dantleech you have to use the new syntax wherever possible. For tests testing the BC layers, add |
@wouterj would that fix the tests? they work in all other environments other than the |
@dantleech other tests are run with weak mode for deprecations (that's not really great, but let's change that in another PR), so deprecation notices won't show up as errors. The problem is that many of the test fixtures still use strings for uri schema, e.g. https://github.com/symfony-cmf/RoutingAutoBundle/blob/multiple_routes/Tests/Resources/app/config/routing_auto.yml |
Yeah I can fix that, but the tests pass in all the other envs. I guess it is an earlier version of the deprecation code that makes it fail with the lowest deps? Will adding the |
@dantleech tests pass in other envs, as the PHPUnit deprecation helper is set to weak. We should avoid using deprecated things as much as possible, so please fix the test configuration :) |
4bfc74b
to
4649408
Compare
Only one deprecation warning now - about the |
Ignore last comment -- all the deprecations are fixed. |
950c900
to
0a861cf
Compare
0a861cf
to
4a21a75
Compare
@@ -24,7 +25,7 @@ | |||
<services> | |||
<service | |||
id="cmf_routing_auto.slugifier" | |||
class="Symfony\Cmf\Bundle\CoreBundle\Slugifier\CallbackSlugifier" | |||
class="Symfony\Cmf\Api\Slugifier\CallbackSlugifier" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also be merged into 1.1, I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created issue #179
@wouterj why is the helper set to weak for non-lowest deps ? This looks weird to me. I generally do the opposite (as lowest deps might end up triggering some deprecations by uisng a version of the deps before they stopped using the deprecated API of the other package) |
Integrates: symfony-cmf/routing-auto#62
Note that this PR revealed a bug: #171 and I do not currently think it is related to this PR.