Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Support for multiple routes #172

Merged
merged 1 commit into from
Feb 23, 2016
Merged

Support for multiple routes #172

merged 1 commit into from
Feb 23, 2016

Conversation

dantleech
Copy link
Member

Integrates: symfony-cmf/routing-auto#62

Note that this PR revealed a bug: #171 and I do not currently think it is related to this PR.

factory-method="getMetadataFactory"
/>
class="%cmf_routing_auto.metadata.factory.class%">
<factory service="cmf_routing_auto.metadata.factory.builder" method="getMetadataFactory" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm .. this is 2.6 only, should I revert this..

@lsmith77 lsmith77 added review and removed wip/poc labels Dec 18, 2015
@dantleech dantleech force-pushed the multiple_routes branch 4 times, most recently from f59d0a3 to 2897c54 Compare December 20, 2015 10:56
@dantleech
Copy link
Member Author

Failing on lowest dependencies because of deprecations: https://travis-ci.org/symfony-cmf/RoutingAutoBundle/jobs/97946914 /cc @wouterj

@wouterj
Copy link
Member

wouterj commented Dec 20, 2015

@dantleech you have to use the new syntax wherever possible. For tests testing the BC layers, add /** @group legacy */ to the test class/test method.

@dantleech
Copy link
Member Author

@wouterj would that fix the tests? they work in all other environments other than the --prefer-lowest one.

@wouterj
Copy link
Member

wouterj commented Dec 20, 2015

@dantleech other tests are run with weak mode for deprecations (that's not really great, but let's change that in another PR), so deprecation notices won't show up as errors.

The problem is that many of the test fixtures still use strings for uri schema, e.g. https://github.com/symfony-cmf/RoutingAutoBundle/blob/multiple_routes/Tests/Resources/app/config/routing_auto.yml

@dantleech
Copy link
Member Author

Yeah I can fix that, but the tests pass in all the other envs. I guess it is an earlier version of the deprecation code that makes it fail with the lowest deps? Will adding the @group legacy stop it failing?

@wouterj
Copy link
Member

wouterj commented Dec 23, 2015

@dantleech tests pass in other envs, as the PHPUnit deprecation helper is set to weak.

We should avoid using deprecated things as much as possible, so please fix the test configuration :)

@dantleech
Copy link
Member Author

Only one deprecation warning now - about the translateObject having to return an object, when using the lowest deps. it is using an older version of the component. Should we boost the requirement for the RoutingAuto component?

@dantleech
Copy link
Member Author

Ignore last comment -- all the deprecations are fixed.

@dantleech dantleech force-pushed the multiple_routes branch 4 times, most recently from 950c900 to 0a861cf Compare February 20, 2016 16:39
@@ -24,7 +25,7 @@
<services>
<service
id="cmf_routing_auto.slugifier"
class="Symfony\Cmf\Bundle\CoreBundle\Slugifier\CallbackSlugifier"
class="Symfony\Cmf\Api\Slugifier\CallbackSlugifier"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also be merged into 1.1, I guess?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue #179

dantleech added a commit that referenced this pull request Feb 23, 2016
@dantleech dantleech merged commit ddb0e63 into master Feb 23, 2016
@dantleech dantleech deleted the multiple_routes branch February 23, 2016 10:38
@dantleech dantleech removed the review label Feb 23, 2016
@stof
Copy link

stof commented Feb 23, 2016

tests pass in other envs, as the PHPUnit deprecation helper is set to weak.

@wouterj why is the helper set to weak for non-lowest deps ? This looks weird to me. I generally do the opposite (as lowest deps might end up triggering some deprecations by uisng a version of the deps before they stopped using the deprecated API of the other package)

@wouterj
Copy link
Member

wouterj commented Feb 23, 2016

@stof I've improved it in the 1.1 branch: 724db6a The original config was from some months back: Lower versions didn't have any deprecations and the newer ones were having deprecations caused by third party bundles.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants