Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Replace Extension subclasses #444

Merged
merged 1 commit into from
Aug 28, 2024
+6 −8
Merged

API Replace Extension subclasses #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Extensions/MaintenanceLockExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use SilverStripe\Forms\CheckboxField;
use SilverStripe\Forms\FieldList;
use SilverStripe\ORM\DataExtension;
use SilverStripe\Core\Extension;
use SilverStripe\SiteConfig\SiteConfig;
use Symbiote\QueuedJobs\Services\QueuedJobService;

Expand All @@ -14,9 +14,9 @@
*
* @package Symbiote\QueuedJobs\Extensions
*
* @extends DataExtension<SiteConfig&static>
* @extends Extension<SiteConfig&static>
*/
class MaintenanceLockExtension extends DataExtension
class MaintenanceLockExtension extends Extension
{
/**
* @param FieldList $fields
Expand Down
8 changes: 3 additions & 5 deletions src/Extensions/ScheduledExecutionExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use SilverStripe\Forms\NumericField;
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\Forms\TextField;
use SilverStripe\ORM\DataExtension;
use SilverStripe\Core\Extension;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\FieldType\DBDatetime;
use Symbiote\QueuedJobs\DataObjects\QueuedJobDescriptor;
Expand All @@ -27,9 +27,9 @@
*
* @method QueuedJobDescriptor ScheduledJob()
*
* @extends DataExtension<DataObject&static>
* @extends Extension<DataObject&static>
*/
class ScheduledExecutionExtension extends DataExtension
class ScheduledExecutionExtension extends Extension
{
/**
* @var array
Expand Down Expand Up @@ -107,8 +107,6 @@ protected function updateCMSFields(FieldList $fields)

protected function onBeforeWrite()
{
parent::onBeforeWrite();

if ($this->owner->FirstExecution) {
$changed = $this->owner->getChangedFields();
$changed = (
Expand Down
Loading