Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Set extension hook implementation visibility to protected #427

Merged
merged 1 commit into from
May 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DataObjects/QueuedJobDescriptor.php
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ public function cleanupJob()
}
}

public function onBeforeWrite()
protected function onBeforeWrite()
{
// if a job is marked as 'waiting' for a restart, we need to reset the
// worker it was assigned to, otherwise it'll never pick up and go again if
Expand All @@ -283,7 +283,7 @@ public function onBeforeWrite()
parent::onBeforeWrite();
}

public function onBeforeDelete()
protected function onBeforeDelete()
{
parent::onBeforeDelete();
$this->cleanupJob();
Expand Down
2 changes: 1 addition & 1 deletion src/Extensions/MaintenanceLockExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class MaintenanceLockExtension extends DataExtension
/**
* @param FieldList $fields
*/
public function updateCMSFields(FieldList $fields)
protected function updateCMSFields(FieldList $fields)
{
if (!QueuedJobService::config()->get('lock_file_enabled')) {
return;
Expand Down
4 changes: 2 additions & 2 deletions src/Extensions/ScheduledExecutionExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class ScheduledExecutionExtension extends DataExtension
/**
* @param FieldList $fields
*/
public function updateCMSFields(FieldList $fields)
protected function updateCMSFields(FieldList $fields)
{
$fields->removeByName([
'ExecuteInterval',
Expand Down Expand Up @@ -105,7 +105,7 @@ public function updateCMSFields(FieldList $fields)
}
}

public function onBeforeWrite()
protected function onBeforeWrite()
{
parent::onBeforeWrite();

Expand Down
Loading