FIX Replace assignment with intended comparison #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddnoc
changed the title
oddnoc
changed the title
GuySartorelli
requested changes
Apr 25, 2024
| if ($errno == E_DEPRECATED || $errno = E_USER_DEPRECATED) { | ||
| if (E_DEPRECATED == $errno || E_USER_DEPRECATED == $errno) { |
There was a problem hiding this comment.
Please don't use YODA syntax.
|
Please also retarget this PR to the |
|
Will open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behaviour
If
E_DEPRECATEDis defined and$errnois eitherE_DEPRECATEDorE_USER_DEPRECATED, return fromhandleError().Actual behaviour
If
E_DEPRECATEDis defined and$errnois any value, return fromhandleError(). This means that exceptions are never thrown by the method wheneverE_DEPRECATEDis defined.