Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation string for Toast message "Records reordered." #321

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

TomOudeRengerink
Copy link
Contributor

@TomOudeRengerink TomOudeRengerink commented Jun 3, 2021

Added a translation string for the toast message "Records reordered.".

This message is shown when the GridFieldOrableRows "handReorder" method is called.

I have provided translations for all of the available language files. Please note that these words are translated through Google Translate and therefore might not be 100% correct.

Issues

@GuySartorelli GuySartorelli changed the base branch from 3 to 3.6 December 21, 2023 00:48
@GuySartorelli GuySartorelli force-pushed the orderablerows-translation branch from 0973f27 to 5db84cf Compare December 21, 2023 00:48
@GuySartorelli
Copy link
Collaborator

Thank you for this contribution and sorry it's taken so long to review.

I've removed the translations - please see our translation contribution guide to learn how to contribute those.

I've retargetted and rebased this PR against the 3.6 branch and updated the localisation key to be based on the class name, which is consistent with best practices.

Copy link
Collaborator

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

rawlurlencode() looks like it's required because of the use of decodeURIComponent() in js files

@emteknetnz emteknetnz merged commit 78fa8ba into symbiote:3.6 Jan 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants