API Deprecate renamed validator #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
emteknetnz
force-pushed
the
pulls/6/depr-valid
branch
from
d1f3d63 to
8d83cbe
Compare
emteknetnz
force-pushed
the
pulls/6/depr-valid
branch
from
8d83cbe to
d7abf47
Compare
emteknetnz
commented
Dec 3, 2024
| { | ||
| $message = 'Will be renamed to Symbiote\\AdvancedWorkflow\\Forms\\AWRequiredFieldsValidator'; | ||
| Deprecation::noticeWithNoReplacment('5.4.0', $message, Deprecation::SCOPE_CLASS); | ||
| parent::__construct(...func_get_args()); |
There was a problem hiding this comment.
RequiredFields constructor uses func_get_args() https://github.com/silverstripe/silverstripe-framework/blob/5/src/Forms/RequiredFields.php#L31
emteknetnz
force-pushed
the
pulls/6/depr-valid
branch
from
d7abf47 to
dbb5a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10908