ENH Update status flag styling #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Nov 20, 2024
Comment on lines
+27
to
+31
| .badge.status-workflow-approval { | ||
| background-color: #E8FAFF; | ||
| border-color: #0070B4; | ||
| color: #0070B4; | ||
| } |
There was a problem hiding this comment.
This bit used to be in silverstripe/admin for some reason.
7 tasks
Status flags can be displayed in multiple places now, so this change gives them the same styling regardless of where they're displayed.
GuySartorelli
force-pushed
the
pulls/7/status-flags
branch
from
90de605 to
5a1cedb
Compare
emteknetnz
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status flags are made generic in silverstripe/silverstripe-framework#11460 and can be displayed in multiple places now.
This PR gives them the same styling regardless of where they're displayed, instead of specifying that the styling is for the site tree badges only.
Issue
SiteTreeinCMSMainsilverstripe/silverstripe-cms#2947