API Set extension hook implementation visibility to protected

symbiote · May 16, 2024 · b970d53 · b970d53
1 parent 6cf3faa
commit b970d53
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/src/Extensions/AdvancedWorkflowExtension.php b/src/Extensions/AdvancedWorkflowExtension.php
@@ -106,7 +106,7 @@ public function updateEditForm(Form $form)
     /**
      * @param Form $form
      */
-    public function updateItemEditForm($form)
+    protected function updateItemEditForm($form)
     {
         /** @var DataObject $record */
         $record = $form->getRecord();

diff --git a/src/Extensions/FileWorkflowApplicable.php b/src/Extensions/FileWorkflowApplicable.php
@@ -17,13 +17,13 @@
  */
 class FileWorkflowApplicable extends WorkflowApplicable
 {
-    public function updateSummaryFields(&$fields)
+    protected function updateSummaryFields(&$fields)
     {
         $fields['ID'] = 'ID';
         $fields['ParentID'] = 'ParentID';
     }
 
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         if (!$this->owner->ID) {
             return $fields;

diff --git a/src/Extensions/WorkflowApplicable.php b/src/Extensions/WorkflowApplicable.php
@@ -106,12 +106,12 @@ public function isPublishJobRunning()
      */
     protected $currentInstance;
 
-    public function updateSettingsFields(FieldList $fields)
+    protected function updateSettingsFields(FieldList $fields)
     {
         $this->updateFields($fields);
     }
 
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         if (!$this->owner->hasMethod('getSettingsFields')) {
             $this->updateFields($fields);
@@ -184,7 +184,7 @@ public function updateFields(FieldList $fields)
         }
     }
 
-    public function updateCMSActions(FieldList $actions)
+    protected function updateCMSActions(FieldList $actions)
     {
         $active = $this->getWorkflowService()->getWorkflowFor($this->owner);
         $c = Controller::curr();

diff --git a/src/Extensions/WorkflowEmbargoExpiryExtension.php b/src/Extensions/WorkflowEmbargoExpiryExtension.php
@@ -91,7 +91,7 @@ class WorkflowEmbargoExpiryExtension extends DataExtension
     /**
      * @param FieldList $fields
      */
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         // requirements
         // ------------
@@ -246,7 +246,7 @@ protected function ensureUnPublishJob($when)
             ->queueJob($job, $when ? date('Y-m-d H:i:s', $when) : null);
     }
 
-    public function onBeforeDuplicate($original, $doWrite)
+    protected function onBeforeDuplicate($original, $doWrite)
     {
         $clone = $this->owner;
 
@@ -341,7 +341,7 @@ public function onBeforeWrite()
      *
      * @param $flags
      */
-    public function updateStatusFlags(&$flags)
+    protected function updateStatusFlags(&$flags)
     {
         $embargo = $this->getIsPublishScheduled();
         $expiry = $this->getIsUnPublishScheduled();