ENH Remove unnecessary condition

symbiote · Aug 22, 2024 · 1d64985 · 1d64985
1 parent a53744b
commit 1d64985
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/Actions/NotifyUsersWorkflowAction.php b/src/Actions/NotifyUsersWorkflowAction.php
@@ -185,7 +185,7 @@ public function getContextFields(DataObject $target)
         }
 
         if ($target instanceof CMSPreviewable) {
-            $result['CMSLink'] = $target->CMSEditLink();
+            $result['CMSLink'] = $target->getCMSEditLink();
         } elseif ($target->hasMethod('WorkflowLink')) {
             $result['CMSLink'] = $target->WorkflowLink();
         }

diff --git a/src/Admin/AdvancedWorkflowAdmin.php b/src/Admin/AdvancedWorkflowAdmin.php
@@ -286,9 +286,7 @@ public function userObjects(Member $user, $fieldName)
             // Title property..
             $instance->setField('Title', $target->getField('Title'));
             $instance->setField('LastEdited', $target->getField('LastEdited'));
-            if (method_exists($target, 'CMSEditLink')) {
-                $instance->setField('ObjectRecordLink', $target->CMSEditLink());
-            }
+            $instance->setField('ObjectRecordLink', $target->getCMSEditLink());
 
             $list->push($instance);
         }

diff --git a/src/Extensions/WorkflowApplicable.php b/src/Extensions/WorkflowApplicable.php
@@ -304,7 +304,7 @@ public function AbsoluteEditLink()
         $CMSEditLink = null;
 
         if ($this->owner instanceof CMSPreviewable) {
-            $CMSEditLink = $this->owner->CMSEditLink();
+            $CMSEditLink = $this->owner->getCMSEditLink();
         } elseif ($this->owner->hasMethod('WorkflowLink')) {
             $CMSEditLink = $this->owner->WorkflowLink();
         }