Skip to content

Commit

Permalink
ENH Update code to reflect changes in template layer (#556)
Browse files Browse the repository at this point in the history
  • Loading branch information
GuySartorelli authored Oct 30, 2024
1 parent f2e189e commit 13d1eaa
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
11 changes: 5 additions & 6 deletions src/Actions/NotifyUsersWorkflowAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Symbiote\AdvancedWorkflow\Actions;

use SilverStripe\Control\Email\Email;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Forms\HeaderField;
use SilverStripe\Forms\LiteralField;
use SilverStripe\Forms\TextareaField;
Expand All @@ -14,7 +15,8 @@
use SilverStripe\Security\Member;
use SilverStripe\Security\Security;
use SilverStripe\Model\ArrayData;
use SilverStripe\View\SSViewer;
use SilverStripe\View\TemplateEngine;
use SilverStripe\View\ViewLayerData;
use Swift_RfcComplianceException;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowAction;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowInstance;
Expand Down Expand Up @@ -134,10 +136,7 @@ public function execute(WorkflowInstance $workflow)
]);
}


$view = SSViewer::fromString($this->EmailTemplate);
$this->extend('updateView', $view);

$engine = Injector::inst()->create(TemplateEngine::class);
foreach ($members as $member) {
if ($member->Email) {
// We bind in the assignee at this point, as it changes each loop iteration
Expand All @@ -146,7 +145,7 @@ public function execute(WorkflowInstance $workflow)
$item->Assignee = ArrayData::create($assigneeVars);
}

$body = $view->process($item);
$body = $engine->renderString($this->EmailTemplate, ViewLayerData::create($item));

$email = Email::create();
try {
Expand Down
2 changes: 1 addition & 1 deletion src/Admin/WorkflowDefinitionImporter.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public function parseYAMLImport($source)
$convertLF = str_replace(array("\r\n", "\r"), "\n", $source ?? '');
/*
* Remove illegal colons from Transition/Action titles, otherwise sfYamlParser will barf on them
* Note: The regex relies on there being single quotes wrapped around these in the export .ss template
* Note: The regex relies on there being single quotes wrapped around these in the export template
*/
$converted = preg_replace("#('[^:\n][^']+)(:)([^']+')#", "$1;$3", $convertLF ?? '');
$parts = preg_split('#^---$#m', $converted ?? '', -1, PREG_SPLIT_NO_EMPTY);
Expand Down

0 comments on commit 13d1eaa

Please sign in to comment.