Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(documentation, styles): shadow utilities #4361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/red-comics-cough.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@swisspost/design-system-documentation': patch
'@swisspost/design-system-styles': patch
---

Internalized bootstrap shadow utility into the design system.
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { Canvas, Controls, Meta, Source } from '@storybook/blocks';
import * as ShadowStories from './shadow.stories';

<Meta of={ShadowStories} />

# Shadow

<div className="lead">The shadow property controls an element's box shadow.</div>

Available values are the following: `.shadow`, `.shadow-sm`, `.shadow-lg` and `.shadow-none`.

<Canvas sourceState="shown" of={ShadowStories.Default} />
<div className="hide-col-default">
<Controls of={ShadowStories.Default} />
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import type { Args, StoryContext, StoryObj } from '@storybook/web-components';
import { html } from 'lit';
import { schemes } from '@/shared/snapshots/schemes';
import meta from './shadow.stories';

const { id, ...metaWithoutId } = meta;

export default {
...metaWithoutId,
title: 'Snapshots',
};

type Story = StoryObj;

export const Shadow: Story = {
render: (_args: Args, context: StoryContext) => {
return schemes(
() => html`
<div class="d-flex gap-32 flex-column">
${(context.argTypes.shadow.options as string[]).map(shadow =>
meta.render?.({ ...meta.args, shadow }, context),
)}
</div>
`,
);
},
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import type { Args, StoryObj, StoryFn, StoryContext } from '@storybook/web-components';
import { html } from 'lit';
import './shadow.styles.scss';
import { MetaExtended } from '@root/types';

export const ShadowLabels: { [key: string]: string } = {
'shadow': 'Default shadow',
'shadow-sm': 'Small shadow',
'shadow-lg': 'Large shadow',
'shadow-none': 'No shadow',
};

const meta: MetaExtended = {
id: '69f2b7e0-827d-4a7a-8580-5ff46dac276d',
title: 'Utilities/Shadow',
args: {
shadow: 'shadow',
},
argTypes: {
shadow: {
name: 'Shadow',
description: 'Size of the shadow',
control: {
type: 'select',
labels: ShadowLabels,
},
options: ['shadow', 'shadow-sm', 'shadow-lg', 'shadow-none'],
table: {
category: 'General',
},
},
},
render: (args: Args) => {
return html` <div class="${args.shadow}">${ShadowLabels[args.shadow]}</div> `;
},
decorators: [
(story: StoryFn, context: StoryContext) => {
const storyTemplate = html`<div class="shadow-example">${story(context.args, context)}</div>`;
return storyTemplate;
},
],
};

export default meta;

type Story = StoryObj;

export const Default: Story = {};
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
@use '@swisspost/design-system-styles/core' as post;

.shadow-example [class|='shadow'] {
border-radius: post.$border-radius;
padding: 1rem;
}
2 changes: 2 additions & 0 deletions packages/styles/src/themes/bootstrap/_utilities.scss
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,6 @@ $utilities: map.remove($utilities, 'overflow');
$utilities: map.remove($utilities, 'overflow-x');
$utilities: map.remove($utilities, 'overflow-y');

$utilities: map.remove($utilities, 'shadow');

@import 'bootstrap/scss/utilities/api';
11 changes: 11 additions & 0 deletions packages/styles/src/utilities/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
@use './functions' as *;

@use '../variables/sizing' as *;
@use '../variables/commons';
/*
Utilities are generated with our utility API using bellow $utilities map.
Expand Down Expand Up @@ -424,5 +425,15 @@ $utilities: (
property: overflow-y,
values: auto hidden visible scroll,
),
'shadow': (
property: box-shadow,
class: shadow,
values: (
null: commons.$box-shadow,
sm: commons.$box-shadow-sm,
lg: commons.$box-shadow-lg,
none: none,
),
),
// IMPORTANT: When adding new utilities here, please ensure to remove the corresponding bootstrap utilities in `src/themes/bootstrap/_utilities.scss`.
);
Loading