fix(components): fix the language switch keyboard navigation #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alizedebray
requested review from
oliverschuerch
and removed request for
a team
🦋 Changeset detectedLatest commit: b8b6948 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
leagrdv
reviewed
Dec 19, 2024
|
I realized that when using the keyboard and selecting one of the menu options, it doesn't select it. I'll fix it on my PR. |
leagrdv
approved these changes
Dec 19, 2024
Co-authored-by: Lea <[email protected]>
oliverschuerch
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Looks good to me. The only thing a recoginzed is the same @leagrdv already mentioned.
And of course the failing e2e tests...
|
alizedebray
merged commit f5054b1
into
4248-language-switch-improvement
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to the post-menu are part of the PR #4337 that should be merge before this one.
ℹ️ Only the commit b899725 needs to be reviewed in this PR.