Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check props on componentDidLoad #3775 #3796

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

gfellerph
Copy link
Member

No description provided.

Delays the prop checks until the last lifecycle hook to give frameworks
time to render their props before the check runs.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gfellerph gfellerph requested review from a team as code owners October 18, 2024 11:19
@gfellerph gfellerph requested a review from alizedebray October 18, 2024 11:19
Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: e1d6ec2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@swisspost/design-system-components Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-demo Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header-showcase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gfellerph gfellerph changed the base branch from main to release/v8 October 18, 2024 11:19
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 18, 2024

Related Previews

@alizedebray alizedebray reopened this Oct 18, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem, unsafe 0 11.2 MB prettier-bot

🚮 Removed packages: npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@cypress/[email protected], npm/@floating-ui/[email protected], npm/@kurbar/[email protected], npm/@lit/[email protected], npm/@ng-bootstrap/[email protected], npm/@oddbird/[email protected], npm/@open-wc/[email protected], npm/@percy/[email protected], npm/@percy/[email protected], npm/@stencil-community/[email protected], npm/@stencil/[email protected], npm/@stencil/[email protected], npm/@stencil/[email protected], npm/@stencil/[email protected], npm/@stencil/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@swimlane/[email protected], npm/@tokens-studio/[email protected], npm/@tsconfig/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@web-types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

@gfellerph gfellerph merged commit 4f11541 into release/v8 Oct 23, 2024
13 checks passed
@gfellerph gfellerph deleted the cherry-pick-prop-checks branch October 23, 2024 05:34
gfellerph pushed a commit that referenced this pull request Oct 28, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to release/v8, this
PR will be updated.


# Releases
## @swisspost/[email protected]

### Minor Changes

- Added icons number 2613, 2614, 2615, 2616, 2617, 2618, 2619 and 2620.
(by [@swisspost-bot](https://github.com/swisspost-bot) with
[#3779](#3779))

- Added icons number 2621, 2622, 2623, 2624, 2625, 2626, 2627, 2628,
2629, 2630 and 2631. (by
[@swisspost-bot](https://github.com/swisspost-bot) with
[#3831](#3831))

## @swisspost/[email protected]

### Patch Changes

- Fixed a bug in nested accordions where closing a child item
unintentionally closed all parent accordion elements. (by
[@gfellerph](https://github.com/gfellerph) with
[#3773](#3773))

- Fixed an issue with property validation where some checks were run
before the framework had the chance to add computed properties (for
example Angular bindings like `[for]="$id"`). The checks are now delayed
to work around this issue. (by
[@gfellerph](https://github.com/gfellerph) with
[#3796](#3796))

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Fixed an issue with property validation where some checks were run
before the framework had the chance to add computed properties (for
example Angular bindings like `[for]="$id"`). The checks are now delayed
to work around this issue. (by
[@gfellerph](https://github.com/gfellerph) with
[#3796](#3796))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Fixed the issue where the background became transparent on `textarea`
focus (by [@veyaromain](https://github.com/veyaromain) with
[#3573](#3573))

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]



## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Fixed an issue with property validation where some checks were run
before the framework had the chance to add computed properties (for
example Angular bindings like `[for]="$id"`). The checks are now delayed
to work around this issue. (by
[@gfellerph](https://github.com/gfellerph) with
[#3796](#3796))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
schaertim pushed a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants