Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): reworked get-function for tokens #3704

Merged
merged 6 commits into from
Oct 11, 2024
Merged

fix(styles): reworked get-function for tokens #3704

merged 6 commits into from
Oct 11, 2024

Conversation

schaertim
Copy link
Contributor

No description provided.

@schaertim schaertim requested a review from a team as a code owner October 9, 2024 13:14
@schaertim schaertim linked an issue Oct 9, 2024 that may be closed by this pull request
Rework tokens.get() function to take token key as single string #3694
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d5d6272

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 9, 2024 •
edited
Loading

Related Previews

alizedebray
alizedebray reviewed Oct 9, 2024
View reviewed changes
packages/documentation/.storybook/styles/components/typo.scss Outdated
@@ -30,7 +30,7 @@ body {
}

.docs-story > :first-child {
font-family: tokens.get('post-body', 'font-family');
font-family: tokens.get('post-body-font-family');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR would be a good opportunity to remove the "post-" prefix, don't you think?

Suggested change
font-family: tokens.get('post-body-font-family');
font-family: tokens.get('body-font-family');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the post- prefix is optional. By removing it do you mean just removing it from the method calls using it right now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alizedebray This has been implemented as you suggested it now 😉

@alizedebray
Copy link
Contributor

Please notify all developers as soon as this PR is merged so that they can update their PR's.

gfellerph
gfellerph requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schaertim please address the linting error

@schaertim schaertim requested a review from gfellerph October 10, 2024 06:59
@oliverschuerch oliverschuerch removed their request for review October 10, 2024 13:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oliverschuerch oliverschuerch merged commit 8255435 into main Oct 11, 2024
11 checks passed
@oliverschuerch oliverschuerch deleted the 3694-rework-tokensget-function-to-take-token-key-as-single-string branch October 11, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch oliverschuerch left review comments

@alizedebray alizedebray alizedebray approved these changes

@gfellerph gfellerph gfellerph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework tokens.get() function to take token key as single string
5 participants
@schaertim @swisspost-bot @alizedebray @gfellerph @oliverschuerch