Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components, documentation): add e2e tests for nested accordions #3634

Merged
merged 1 commit into from
Oct 11, 2024
Merged

chore(components, documentation): add e2e tests for nested accordions #3634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions packages/components/cypress/e2e/accordion.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,42 @@ describe('accordion', () => {
describe('nested', () => {
beforeEach(() => {
cy.getComponent('accordion', ACCORDION_ID, 'nested');
cy.get('@accordion').find('post-accordion post-accordion-item').as('nestedCollapsibles');
cy.get('@accordion').find('post-accordion-item').as('collapsibles');
});

it('should show the first nested element of the first element', () => {
cy.get('@collapsibles').eq(1).click();
cy.get('@collapsibles').eq(1).shadow().find('post-collapsible').should('be.visible');
});

it('should not show the first nested element as expanded after clicking the last nested element', () => {
cy.get('@collapsibles').eq(2).click();
cy.get('@collapsibles').eq(1).shadow().find('post-collapsible').should('be.hidden');
cy.get('@collapsibles').eq(2).shadow().find('post-collapsible').should('be.visible');
});

it('should show the first nested element wrapped in a div in the second parent accordion element', () => {
cy.get('@collapsibles').eq(4).click();
cy.get('@collapsibles').eq(5).click();
cy.get('@collapsibles').eq(4).shadow().find('post-collapsible').should('be.visible');
cy.get('@collapsibles').eq(5).shadow().find('post-collapsible').should('be.visible');
});

it('should not show the first nested element wrapped in a div as expanded after clicking the last nested element', () => {
cy.get('@collapsibles').eq(4).click();
cy.get('@collapsibles').eq(7).click();
cy.get('@collapsibles').eq(5).shadow().find('post-collapsible').should('be.hidden');
cy.get('@collapsibles').eq(4).shadow().find('post-collapsible').should('be.visible');
cy.get('@collapsibles').eq(7).shadow().find('post-collapsible').should('be.visible');
});

it('should not propagate "postToggle" event from nested post-accordion', () => {
cy.document().then(document => {
const EventHandlerMock = cy.spy();
Cypress.$(document.querySelector('post-accordion')).on('postToggle', EventHandlerMock);

cy.get('@nestedCollapsibles')
.last()
cy.get('@collapsibles')
.eq(3)
.click()
.then(() => {
expect(EventHandlerMock).to.not.be.called;
Expand Down
1 change: 1 addition & 0 deletions packages/documentation/src/stories/components/accordion/accordion.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export const Nested: Story = {
<post-accordion-item>
${getAccordionItemContent(mainAccordionIndex + 1, args.headingLevel)}
${mainAccordionIndex === 0 ? getNestedAccordion() : nothing}
<div>${mainAccordionIndex === 1 ? getNestedAccordion() : nothing}</div>
</post-accordion-item>
`;
}),
Expand Down