feat(styles): tokenise radio buttons #3540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 8825864 Author: Tim Schär <[email protected]> Date: Tue Sep 10 15:22:04 2024 +0200 fix(setup): build tokens before styles is started
4 tasks
🦋 Changeset detectedLatest commit: 98afc4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7 tasks
schaertim
changed the title
|
alizedebray
changed the title
alizedebray
requested changes
Oct 25, 2024
| '@swisspost/design-system-styles': patch | ||
| --- | ||
|
|
||
| Started adapting the radio-button styles to match v2 design. |
There was a problem hiding this comment.
Suggested change
| Started adapting the radio-button styles to match v2 design. | |
| Aligned radio button styles with the new Post design. |
Comment on lines
+12
to
+13
| @use '../tokens/components' as components; | ||
| @use '../functions/tokens' as tokens; |
There was a problem hiding this comment.
This is not necessary:
Suggested change
| @use '../tokens/components' as components; | |
| @use '../functions/tokens' as tokens; | |
| @use '../tokens/components'; | |
| @use '../functions/tokens'; |
| transition: color animation.$transition-base-timing; | ||
| color: tokens.get('radio-button-enabled-fg'); | ||
| background-color: tokens.get('radio-button-enabled-bg'); | ||
| transition: color #{animation.$transition-base-timing}; |
There was a problem hiding this comment.
Suggested change
| transition: color #{animation.$transition-base-timing}; | |
| transition: color animation.$transition-base-timing; |
| height: tokens.get('radio-button-icon-ring'); | ||
| width: tokens.get('radio-button-icon-ring'); | ||
| border: tokens.get('radio-button-icon-border-width') solid | ||
| tokens.get('radio-button-enabled-stroke'); | ||
| margin-top: 1px; |
There was a problem hiding this comment.
What is this margin for? Can it be removed?
If not can you add a comment to explain it?
Comment on lines
+118
to
+119
| // TODO: Use tokens | ||
| border: 3px solid transparent; |
There was a problem hiding this comment.
Did you contact @Vandapanda to create the missing tokens?
| @@ -149,6 +167,9 @@ | |||
| } | |||
| } | |||
|
|
|||
| border: 0; | |||
| background-image: url('#{form-check.$form-check-input-disabled-background-url-light-lg}'); | |||
There was a problem hiding this comment.
Is this still correct or do we simply use a dashed border now?
|
|
||
| .form-check { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| row-gap: form-check.$form-check-row-gap; | ||
| margin-bottom: form-check.$form-check-margin-bottom; | ||
|
|
||
| @include utility-mx.focus-style() { | ||
| @include utility-mx.focus-style-custom() { |
There was a problem hiding this comment.
You can use the focus-style mixin here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2 design implementation is currently incomplete due to several factors:
To address these issues and track progress, a new ticket ([component]: Radio Button (rework) #3537 ) has been created to document the necessary steps for full implementation.