Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components): export accordion, popover and popovercontainer #2424

Merged
merged 1 commit into from
Jan 4, 2024
Merged

chore(components): export accordion, popover and popovercontainer #2424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/components/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
export { Components, JSX } from './components';

// Export every single component so it gets included in the dist output
export { PostAccordion } from './components/post-accordion/post-accordion';
export { PostAlert } from './components/post-alert/post-alert';
export { PostCollapsible } from './components/post-collapsible/post-collapsible';
export { PostIcon } from './components/post-icon/post-icon';
export { PostPopover } from './components/post-popover/post-popover';
export { PostPopovercontainer } from './components/post-popovercontainer/post-popovercontainer';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverschuerch This is actually an undocumented (internal) component, should it still be exported here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I would say "no".
But as long as stencil is generating the types for this component and putting them in the components.d.ts file, we need to export all the components. Otherwise we will not be able to release a bug-free components-angular package.

I have created a ticket to address this problem: #2426.

export { PostTabs } from './components/post-tabs/post-tabs';
export { PostTabHeader } from './components/post-tab-header/post-tab-header';
export { PostTabPanel } from './components/post-tab-panel/post-tab-panel';
Expand Down
Loading