You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think if we update our deploy-to-netifly action to use a filter with a package name we pass to this action then using netifly v16 would be no Problem.
However @oliverschuerch and myself @b1aserlu failed to come up with a way to properly test this. As for some reason the deploy worklfows are only triggered from main and not as expected from the current branch.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Revert "setup a way to test my worklfow action"
This reverts commit afaf0c5.
setup a way to test my worklfow action
changes deploy worklfow for testing purpose
Checkout head
try again
tries to use actions from current branch
another one
additional commit to maybe trigger moified action
updates netifly in deploy action exptected to fail
@b1aserlu, @oliverschuerch the fact that deploy workflows are run from main is a security feature. This allows us to not use the github secrets for feature branches or pull requests from forks where they could potentially be stolen.
Therefore, the only way to test this, is on main. Not ideal, but secure.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b1aserlu
force-pushed
the
1796-update-netlify-cli-to-v16
branch
from
I think if we update our deploy-to-netifly action to use a filter with a package name we pass to this action then using netifly v16 would be no Problem.
However @oliverschuerch and myself @b1aserlu failed to come up with a way to properly test this. As for some reason the deploy worklfows are only triggered from main and not as expected from the current branch.