Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use bash 'AND' instead of background task #2335

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

gfellerph
Copy link
Member

https://stackoverflow.com/questions/26770568/vs-with-the-test-command-in-bash

& means "run this task in the background". This is not recommended here as it might not be finished when the build is trying to write new files.

I'm not sure that this will solve the build error we experienced on some runs, but it's certainly a step into the right direction.

https://stackoverflow.com/questions/26770568/vs-with-the-test-command-in-bash

& means "run this task in the background". This is not recommended here as it might not be finished when the build is trying to write new files.

I'm not sure that this will solve the build error we experienced on some runs, but it's certainly a step into the right direction.
Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: 00b2077

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Storybook complains about finding two favicons. Safari currently does not support svg favicons, falling back to the classic .ico deals with the warning
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 1, 2023

Preview environment ready: https://preview-2335--swisspost-design-system-next.netlify.app

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 1, 2023

Preview environment ready: https://preview-2335--swisspost-web-frontend.netlify.app

Pnpm does not run pre* tasks by default. I think it's a security measure.
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gfellerph gfellerph merged commit a9f6398 into main Dec 4, 2023
10 checks passed
@gfellerph gfellerph deleted the fix-storybook-build-issues branch December 4, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants