Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): deprecate regular breakpoint #2238

Merged
merged 40 commits into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
3a5f500
feat(documentation): adds container story
b1aserlu Sep 6, 2023
637ce02
feat(documentation): cleans up container stories
b1aserlu Sep 6, 2023
919e990
feat(documentation): adds container story
b1aserlu Oct 3, 2023
29582fe
feat(styles): adjust breakpoints and visually get rid of the deprecat…
oliverschuerch Oct 4, 2023
fcd7e89
chore: add changeset
oliverschuerch Oct 5, 2023
368ecdc
chore(documentation): add deprecation info in breakpoints docs page
oliverschuerch Oct 5, 2023
126da86
chore: update changeset
oliverschuerch Oct 5, 2023
d3a4f78
Merge branch 'main' into 1047-story-containers-1
b1aserlu Oct 18, 2023
7db0706
feat(documentation): update container story to look more like grid story
b1aserlu Oct 18, 2023
fc6d648
feat(documentation): update container story to look more like grid story
b1aserlu Oct 18, 2023
27f9a03
feat(documentation): adds story for sizing
b1aserlu Oct 19, 2023
2bc90b9
Apply suggestions from code review
b1aserlu Oct 19, 2023
453f2de
Revert "feat(documentation): adds story for sizing"
b1aserlu Oct 24, 2023
54c8079
feat(documentation): adds story for sizing
b1aserlu Oct 31, 2023
756232f
Merge branch 'main' into 1047-story-containers-1
oliverschuerch Nov 3, 2023
eae2db9
fix(documentation): breakpoints code examples
oliverschuerch Nov 3, 2023
6f64e77
chore(documentation): update breakpoints docs page structure
oliverschuerch Nov 3, 2023
9a987d9
fix(documentation): grid-system code examples
oliverschuerch Nov 3, 2023
e9b2a41
chore(documentation): update grid-system docs page structure
oliverschuerch Nov 3, 2023
956b740
chore(styles): cleanup grid variables file
oliverschuerch Nov 3, 2023
cb4365d
chore(documentation): update layout shared scss module
oliverschuerch Nov 3, 2023
0a41adb
feat(documentation): add containers docs page
oliverschuerch Nov 3, 2023
ce1f7dd
chore(documentation): update heading of grid docs page
oliverschuerch Nov 3, 2023
48effbf
chore(documentation): remove unnecessary import
oliverschuerch Nov 3, 2023
dbe89ed
refactor(documentation): reducing code duplication in layout docs
oliverschuerch Nov 3, 2023
b2aaf56
Merge branch 'main' into 1047-story-containers-1
oliverschuerch Nov 3, 2023
0589c57
chore: add changeset and update todos
oliverschuerch Nov 7, 2023
a7d3b19
Merge branch 'main' into 1225-update-breakpoints
oliverschuerch Nov 7, 2023
a13a526
Merge branch '1047-story-containers-1' into 1225-update-breakpoints
oliverschuerch Nov 7, 2023
07e9092
chore(components): add ignorePatterns in eslintrc to exclude itself
oliverschuerch Nov 7, 2023
4f7284e
Merge branch 'main' into 1225-update-breakpoints
oliverschuerch Dec 20, 2023
b1ce3ff
Merge branch 'main' into 1225-update-breakpoints
oliverschuerch Jan 9, 2024
081f11f
Merge branch 'main' into 1225-update-breakpoints
oliverschuerch Jan 9, 2024
1b8045d
chore: revert e2e-tests workflow to make cypress binary work again
oliverschuerch Jan 9, 2024
01652b5
Merge branch 'main' into 1225-update-breakpoints
oliverschuerch Jan 9, 2024
41d299b
Merge branch 'main' into 1225-update-breakpoints
oliverschuerch Jan 11, 2024
469e3ed
Merge branch 'main' into 1225-update-breakpoints
oliverschuerch Jan 18, 2024
608ea41
Merge branch 'main' into 1225-update-breakpoints
oliverschuerch Jan 18, 2024
0891d76
chore: changeset
oliverschuerch Jan 18, 2024
402698c
Merge branch 'main' into 1225-update-breakpoints
oliverschuerch Feb 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/chilled-parrots-pretend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@swisspost/design-system-styles': patch
'@swisspost/design-system-documentation': patch
---

Adjusted breakpoints and visually got rid of the deprecated `rg` breakpoint.
5 changes: 5 additions & 0 deletions .changeset/tricky-tables-warn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-documentation': minor
---

Added a documentation page for the `.container` and `.container-fluid` classes.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ The Swiss Post Design System includes
<span>{Object.keys(SCSS_VARIABLES.breakpoint).length}</span>
breakpoints, sometimes referred to as grid tiers, for building responsively. These breakpoints can be customized if you’re using our source Sass files.

<div className="alert alert-md alert-warning">
<h2 className="alert-heading">The <code>regular</code> Breakpoint is deprecated</h2>
<p>Its CSS helper classes, as well as its SASS variables and mixins will be removed in the future.</p>
</div>

<BreakpointTable />

## CSS
Expand Down
6 changes: 3 additions & 3 deletions packages/styles/src/variables/_breakpoints.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

$grid-breakpoints: (
xs: 0,
sm: 400px,
rg: 600px,
sm: 540px,
rg: 779.96px,
md: 780px,
lg: 1024px,
xl: 1280px,
xxl: 1441px,
xxl: 1440px,
) !default;
Loading
Loading