Support non-Eloquent resource #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @maartenpaauw , Thank you for the PR. The code looks good, but could you add tests to prove that the code works? |
|
The project where we use this package has been postponed. As a result, I haven't had time to write tests yet. |
|
Ah alright. For now I've merged this into a separate branch and I'm expanding on it to include some tests. Thank you for your contribution 😄 |
bbrala
reviewed
Sep 15, 2023
| @@ -167,6 +167,6 @@ public function down(): void | |||
| Schema::dropIfExists('tags'); | |||
| Schema::dropIfExists('comments'); | |||
| Schema::dropIfExists('videos'); | |||
| // Schema::dropIfExists('posts'); | |||
| // Schema::dropIfExists('posts'); | |||
There was a problem hiding this comment.
This is something we should fix in the entire codebase. The entire project does not adhere to our code standards. So every PR gets a load of these formatting issues that need to be resolved. It's something that just needs to be done once. You can have a go at it if you want.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add initial support for non-Eloquent resources
Motivation and context
Laravel JSON:API offers support for non-Eloquent resources.
This PR add initial support for non-Eloquent resources.
It isn't flawless because, the entity under the hood needs to implement
ArrayAccessand have staticallmethod (which is needed to generate examples). But it's a good start.How has this been tested?
Tests are green and the JSON file is generating.
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!