-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispose LSP's output channel on restart #841
Dispose LSP's output channel on restart #841
Conversation
When restarting SourceKit-LSP its output channel was not disposed, which caused a new entry to be added to the output channel list without removing the old one.
This is kind of dodgy, in that we are assuming the VSCode language client never calls the |
After some digging I understand what is happening here, and it does seem to be a bug in vscode-languageclient. The flow is:
This leaves us with one more output channel than we started with. |
Do you want to add an issue for the vscode language client? Oh and add a comment here detailing the issue and that it should be reverted once a fix is in vscode-language-server |
Sounds good, I'll create that issue once I have received internal approval and link it back to here. |
Created microsoft/vscode-languageserver-node#1496 to track the root cause in vscode-language-server-node. |
When restarting SourceKit-LSP its output channel was not disposed, which caused a new entry to be added to the output channel list without removing the old one.
Fixes #839