Address some issues found when running test locally #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michael-weng
commented
Nov 20, 2024
michael-weng
commented
- The build command output is not logged properly in dependency test
- The build command test teardown is not needed and it adds unnecessary run time in the CI
- Check in the default setting for background compilation since updateSettings cannot reset to undefined, this way running locally will not cause git status to show unstaged changes even on test pass
michael-weng
requested review from
adam-fowler,
0xTim and
award999
as code owners
plemarquand
approved these changes
Nov 21, 2024
- Give a little bit more leeway for timeout since CI machine will be slower than development machine
- We want to make sure we don't run spm command quickly in succession - Running unedit command right after spm update command sometime causes CI git to complain about git HEAD corruption
- The spm update command is not stable when used alongside with spm edit, so let's just keep things simple by running the command on defaultPackage instead.
michael-weng
force-pushed
the
local_test_run_fix
branch
from
7616685 to
ab0773b
Compare
award999
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.