Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for Expand Macro actions #1206

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

michael-weng
Copy link
Contributor

@michael-weng michael-weng commented Nov 14, 2024

  • Validate the workflow of user calling Expand Macro actions on a swift project with macro
  • Add test fixture for swift macro
  • Verify expand macro by asserting expanded macro document contain the right macro

Issue: #1205

@michael-weng
Copy link
Contributor Author

We can probably optimize with background compilation integration test, but let's do that after this is merged and we have a few more lsp related integration tests.

@michael-weng michael-weng force-pushed the expand_macro_lsp_itest branch from dc2b562 to 0311171 Compare November 20, 2024 18:56
- Validate the workflow of user calling Inline/Expand Macro actions on
a swift project with macro
- Add test fixture for swift macro
- Verify inline macro by asserting on inlined value after calling the
action
- Verify expand macro by asserting expanded macro document contain the
right macro

Issue: swiftlang#1205
- Also add more explanation to the timeout set by the test suite
@michael-weng michael-weng force-pushed the expand_macro_lsp_itest branch from 09de8b7 to 5072ed5 Compare December 3, 2024 22:13
@michael-weng michael-weng changed the title Add integration tests for Inline/Expand Macro actions Add integration tests for Expand Macro actions Dec 3, 2024
@plemarquand plemarquand merged commit d51edfc into swiftlang:main Dec 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants