-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for the Swift snippets workflows #1126
Conversation
The CI will probably make this apparent so might just be stating the obvious here, but snippet's only implemented in 5.7 so probably need to set some precondition. |
yep thanks :), also seems like it was hidden behind an experimental flag for a bit so trying to run that down |
Nice! If it's a particular flag we are expecting would be a good candidate for a separate contract test, and if anything were to change we will know explicit the contract with the driver's broken. |
- Added comments for clarification - Added utilities to listen for dap message, this is useful for test synchronization. Code takes inspiration from swiftlang#1126
- Added comments for clarification - Added utilities to listen for dap message, this is useful for test synchronization. Code takes inspiration from swiftlang#1126
- Added comments for clarification - Added utilities to listen for dap message, this is useful for test synchronization. Code takes inspiration from swiftlang#1126
- Added comments for clarification - Added utilities to listen for dap message, this is useful for test synchronization. Code takes inspiration from swiftlang#1126
* Add integration tests for build commands - Validate the workflow of user calling the Swift: Run Build/Clean Build/Debug Build commands. - Ensure Swift: Run Build will not get blocked by pre-set breakpoint. - Ensure Swift: Clean Build will result in a cleaned up .build folder. - Ensure Swift: Debug Build will stop on a breakpoint and resume. Issue: #1184 * - Added module enum for workbench commands string constant - Added comments for clarification - Added utilities to listen for dap message, this is useful for test synchronization. Code takes inspiration from #1126 * - Rename from utilies/command.ts to utilies/commands.ts - Minor cosmetic change to utilies/commands.ts * - Fix a bug in updateSettings where promise is not being exlicitly returned, causing restore of setting being not awaitable - Make makeDebugConfigurations to be awaitable - Change launch to also update the key for ASLR disable settings - Make the test properly set up and reset the settings that update the launch config
424d339
to
16ffb37
Compare
* Created some common utilities for dealing with debug sessions * Add integration test for run command and debug variant, big difference being whether the breakpoint is hit or not Issue: swiftlang#1125
CodeLLDB is not working with older toolchains so need to use lldb-dap
being whether the breakpoint is hit or not
Issue: #1125