Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unnecessary navigator delay #920

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marinaaisa
Copy link
Member

@marinaaisa marinaaisa commented Dec 19, 2024

Bug/issue #141189589, if applicable:

Summary

Delete unnecessary navigator delay. It was legacy code that is no longer in need.

This is the commit that introduced the delay-hiding transition in 2022.
It was intended to delay closing the navigator, so the transitions we have for the NavigatorCard would still work and we would also prevent keyboard navigation for AX reasons.

Dependencies

NA

Testing

Steps:

  1. Run the project with a .doccarchive
  2. Go to any documentation page
  3. Assert that the navigator is loading without any delay

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

@marinaaisa marinaaisa requested a review from mportiz08 December 19, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant