Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of <div> in episode 01 #677

Closed
wants to merge 2 commits into from
Closed

Remove the use of <div> in episode 01 #677

wants to merge 2 commits into from

Conversation

martinosorb
Copy link
Contributor

This is apparently needed for the lesson to be workable with Crowdin for internationalisation purposes (see this thread on Slack).

Please note that I can't, at the moment, check whether the version in this PR will actually work in Crowdin -- but the problem there is supposed to be about the use of <div>.

What the PR does is to change the section on Markdown of the first episode to look like this:
image

Also fixes a typo by which the level-2 header looked the same as the level-1 header.

Copy link

github-actions bot commented Apr 13, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-677

The following changes were observed in the rendered markdown documents:

 01-run-quit.md | 211 ++++++++++++++++-----------------------------------------
 md5sum.txt     |   2 +-
 2 files changed, 58 insertions(+), 155 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-04-13 20:16:11 +0000

github-actions bot pushed a commit that referenced this pull request Apr 13, 2024
@alee alee mentioned this pull request Apr 13, 2024
@alee
Copy link
Member

alee commented Apr 13, 2024

thanks @martinosorb ! I'm going to close this PR since it's originating from your main branch which will cause problems down the line (i.e., extraneous merge commits) if merged but I've cherry picked the work into #678

@alee alee closed this Apr 13, 2024
@martinosorb
Copy link
Contributor Author

Thank you so much for the quick response and for the extra work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants