Address issues with more recent PHPStan versions #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ignored some of the issues because they have to do with user input, and I'm not 100% sure I can assert Symfony options or arguments are going to be strings or int all the time.
It seems to run an ancient version of PHPStan.
greg0ire
force-pushed
the
address-latest-phpstan
branch
from
19f91ad
to
edb8064
Compare
greg0ire
force-pushed
the
address-latest-phpstan
branch
from
03b153a
to
d446354
Compare
|
looks good to me. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ignored some of the issues because they have to do with user input,
and I'm not 100% sure I can assert Symfony options or arguments are
going to be strings or int all the time.