Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pop up dialog box for Polls/Survey done ! #702 🌟🌟🌟 #724

Closed
wants to merge 1 commit into from

Conversation

Subhajit-2023-44
Copy link
Contributor

Hello, PR
Add new feature - #702
Add a pop up dialog box for Polls/Survey done properly -

Untitled.video.-.Made.with.Clipchamp.-.2024-10-31T105223.773.mp4

Screenshot 2024-10-31 105052
Screenshot 2024-10-31 105106

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Checklist

  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 5:26am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Subhajit-2023-44! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 60d47c6
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/672314e80451aa00084dc282
😎 Deploy Preview https://deploy-preview-724--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Subhajit-2023-44
Copy link
Contributor Author

@swaraj-das @AnitSarkar123 done, please merge my PR with level 3..

I add a pop up dialog box for Polls/Survey (if you vote once, you won't see it again after reload..) #702

@AnitSarkar123
Copy link
Collaborator

AnitSarkar123 commented Oct 31, 2024

@swaraj-das @AnitSarkar123 done, please merge my PR with level 3..

I add a pop up dialog box for Polls/Survey (if you vote once, you won't see it again after reload..) #702

Great 👍 @Subhajit-2023-44

@AnitSarkar123
Copy link
Collaborator

@swaraj-das @AnitSarkar123 done, please merge my PR with level 3..

I add a pop up dialog box for Polls/Survey (if you vote once, you won't see it again after reload..) #702

Great 👍 @Subhajit-2023-44

@swaraj-das Marge it

@Subhajit-2023-44
Copy link
Contributor Author

@swaraj-das @AnitSarkar123 done, please merge my PR with level 3..
I add a pop up dialog box for Polls/Survey (if you vote once, you won't see it again after reload..) #702

Great 👍 @Subhajit-2023-44

Thank You 🙏🏻

Copy link

github-actions bot commented Nov 1, 2024

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@Subhajit-2023-44
Copy link
Contributor Author

@swaraj-das please merge my PR with Level 3

Thank You

@@ -754,6 +754,210 @@ <h2>Feedback Form</h2>

</script>
</div>

Copy link
Owner

@swaraj-das swaraj-das Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've told everyone multiple times: don’t add CSS or JavaScript directly in HTML file. It will be harder to manage for index.html . When I have to take over the project after your PR, it creates unnecessary issues and makes my job harder. Follow the project structure properly. Let’s keep it clean—separate HTML, CSS, and JavaScript. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swaraj-das okay wait I will give a new PR soon,

But you never told me 😓😓

@Subhajit-2023-44 Subhajit-2023-44 closed this by deleting the head repository Nov 1, 2024
@Subhajit-2023-44
Copy link
Contributor Author

@swaraj-das done #740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants