Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Footer Of Home Page And About Us Page #695

Closed
wants to merge 0 commits into from

Conversation

Adarsh-Chaubey03
Copy link
Contributor

@Adarsh-Chaubey03 Adarsh-Chaubey03 commented Oct 27, 2024

Issue #691 : [BUG] Footer links of About Us Page Are NOT Working solved

Type of PR

  • Bug fix
  • Feature enhancement

Description

  • Added link to the footer of about us page

  • CHANGED color of footer gradient and matching with website theme. (I am happy to revert back if it doesn`t sound well. Do Let Me Know )

  • Removed feed back form from the footer due to following reasons:
    => A contact form already available just above footer
    image
    => Feedback page should be created differently as a new page. It is just causing an oversized footer.
    image

  • Consistent footer on both home and about us page

Screenshots / Videos (if applicable)

  • Footer Now:

image

Checklist

  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

@swaraj-das please review this PR.

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 2:34pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Adarsh-Chaubey03! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 27, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 51707b6
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6729de908c5ac000083082c2
😎 Deploy Preview https://deploy-preview-695--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Adarsh-Chaubey03 Adarsh-Chaubey03 changed the title Updated Footer Of Home Page And About Us` Page Updated Footer Of Home Page And About Us Page Oct 27, 2024
@swaraj-das
Copy link
Owner

swaraj-das commented Oct 27, 2024

@Adarsh-Chaubey03 The color pallet you used is similar and good. But I want, you redesign the footer. There must be a feedback option. The Quick links and stuffs font should be smaller and place the company details in a proper space.

image
Here is bug in visitor count.

@Adarsh-Chaubey03
Copy link
Contributor Author

Adarsh-Chaubey03 commented Oct 27, 2024

@Adarsh-Chaubey03 The color pallet you used is similar and good. But I want, you redesign the footer. There must be a feedback option. The Quick links and stuffs font should be smaller and place the company details in a proper space.

image Here is bug in visitor count.

ok i will correct it. But what if i just add a link in footer for feedback & later create a new page which opens on clicking it
Or..
You want me to add a feedback form itself in footer @swaraj-das
image

@Adarsh-Chaubey03
Copy link
Contributor Author

This Updated Footer

image
@swaraj-das please check this out

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@Adarsh-Chaubey03
Copy link
Contributor Author

@swaraj-das check this out

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

2 similar comments
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@Adarsh-Chaubey03
Copy link
Contributor Author

@swaraj-das check this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants