Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added navbar in contributor's page #678

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Conversation

charrviwadhwa
Copy link
Contributor

Pull Request Format

Added navbar in contributor's page

Issue #666 : Adding navbar in contributor's page

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

  1. Added navbar with the logo and name of website.
  2. Added Home and About us navigation pages in navbar.

Screenshots / Videos (if applicable)

Before:

  • There was a single home button.
    Screenshot (1)

After:

  • Added navbar with logo and navigation links which enhanced the website more.
    Screenshot 2024-10-24 233655

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!
if any changes required please let me know

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 6:13am

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 8e861eb
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/671dda13cad1400008f6c3bb
😎 Deploy Preview https://deploy-preview-678--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @charrviwadhwa! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@charrviwadhwa charrviwadhwa changed the title Added navbar in contributor's ppage Added navbar in contributor's page Oct 24, 2024
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@charrviwadhwa
Copy link
Contributor Author

I have resolved this issue
Please look forward to it

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@charrviwadhwa
Copy link
Contributor Author

Please merge this pr
I have resolved this issue

@swaraj-das
Copy link
Owner

image

@charrviwadhwa Fix the hover effect.

@charrviwadhwa
Copy link
Contributor Author

I will fix

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@charrviwadhwa
Copy link
Contributor Author

charrviwadhwa commented Oct 27, 2024

Screenshot (4)

I have fixed the hover effect
please look forward to the changes made.

@charrviwadhwa
Copy link
Contributor Author

I have fixed this issue
Please merge the pr

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@charrviwadhwa
Copy link
Contributor Author

please merge the pr

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@charrviwadhwa
Copy link
Contributor Author

please merge this pr @swaraj-das

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@swaraj-das swaraj-das merged commit 63862a3 into swaraj-das:main Nov 1, 2024
5 checks passed
Copy link

github-actions bot commented Nov 1, 2024

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants