-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Add Visitor Counter feature done ! #672
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Subhajit-2023-44! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
@swaraj-das @AnitSarkar123 done, merge my PR with level 3, Thank You |
Hi there! This issue is still open. We are looking forward to your response. |
<script src="path/to/visitorCounter.js"></script> | ||
<script src="./assets/css/visitors.css"></script> | ||
|
||
<script src="visi.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don’t add separate files named visi.css
and visi.js
for this feature. Instead, integrate the code directly into style.css
and script.js
. This approach will help keep the file structure simple and prevent confusion, ensuring that other developers can easily understand and navigate the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay 😭😭 I will give new PR wait
<div>Visitor</div> | ||
<div class="website-counter"></div> | ||
</div> | ||
<script src="path/to/visitorCounter.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- <script src="path/to/visitorCounter.js"></script>
- <script src="./assets/css/visitors.css"></script>
What is the meaning of these two lines in code? There is not any path.
Hi there! This issue is still open. We are looking forward to your response. |
Hello, PR
Add Visitor Counter feature done properly - #643 #649
Before -
Type of PR
Checklist
Thank you for reviewing my pull request!