Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Add Visitor Counter feature done ! #672

Closed
wants to merge 1 commit into from

Conversation

Subhajit-2023-44
Copy link
Contributor

@Subhajit-2023-44 Subhajit-2023-44 commented Oct 24, 2024

Hello, PR
Add Visitor Counter feature done properly - #643 #649

Screenshot 2024-10-24 163237

Before -
Screenshot 2024-10-24 163244

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:08am

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 40b001e
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/671a2aa7a4e7dc0008f7247f
😎 Deploy Preview https://deploy-preview-672--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Subhajit-2023-44! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Subhajit-2023-44
Copy link
Contributor Author

@swaraj-das @AnitSarkar123 done, merge my PR with level 3,

Thank You

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@Subhajit-2023-44
Copy link
Contributor Author

@swaraj-das @AnitSarkar123

<script src="path/to/visitorCounter.js"></script>
<script src="./assets/css/visitors.css"></script>

<script src="visi.js"></script>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don’t add separate files named visi.css and visi.js for this feature. Instead, integrate the code directly into style.css and script.js. This approach will help keep the file structure simple and prevent confusion, ensuring that other developers can easily understand and navigate the project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay 😭😭 I will give new PR wait

<div>Visitor</div>
<div class="website-counter"></div>
</div>
<script src="path/to/visitorCounter.js"></script>
Copy link
Owner

@swaraj-das swaraj-das Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • <script src="path/to/visitorCounter.js"></script>
  • <script src="./assets/css/visitors.css"></script>

What is the meaning of these two lines in code? There is not any path.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @Subhajit-2023-44

@Subhajit-2023-44 Subhajit-2023-44 closed this by deleting the head repository Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants