Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linked on the pop-up to Terms of Service and Privacy Policy now works #627

Closed
wants to merge 4 commits into from

Conversation

himasnhu018
Copy link

Pull Request Format
PR Title
Issue #595 : links on the pop-up to Terms of Service and Privacy Policy do not work solved
Type of PR
Add X in the box to specify the improvement type.
Bug fix
Feature enhancement
Documentation update
Other (specify): ___________
Description
This pull request aims to fix the non-functional links to the Terms of Service and Privacy Policy in the popup window of the index.html page. The Privacy Policy link is now properly directed to the PrivacyPolicy.html page, ensuring users can access important information regarding their data and usage policies directly from the popup.

Screenshots / Videos (if applicable)
Before:

The popup contained links to the Terms of Service and Privacy Policy, but they were inactive and did not lead to the respective pages, leading to confusion among users seeking more information.
After:

The popup now features clickable links that correctly navigate users to the Terms of Service and Privacy Policy pages. Users can seamlessly access these critical documents, enhancing user experience and transparency.
Checklist
Add X in the box to specify.
I have performed a self-review of my code.
I have tested the changes thoroughly before submitting this pull request.
I have provided relevant issue numbers, screenshots, and videos after making the changes.
I have commented my code, particularly in hard-to-understand areas.
Additional Context
The main challenge faced was ensuring the links within the popup correctly referenced the appropriate HTML pages without disrupting existing functionality. Careful attention was given to maintain the styling and responsiveness of the popup while ensuring the links are user-friendly. These improvements not only provide direct access to policies but also enhance the overall user experience on the website.

Thank you for reviewing my pull request!

changes in PrivacyPolicy Page and link it to the popup window
linked the Term and conditions and PrivacyPolicy Page to the Popup window
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 4:50am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @himasnhu018! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 44c297d
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6715dd81f024250008f1e33c
😎 Deploy Preview https://deploy-preview-627--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

1 similar comment
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@github-actions github-actions bot added the Stale label Oct 31, 2024
@github-actions github-actions bot closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant