Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fixed the link to Privacy Policy page on the Pop-Up #599

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

KAUSHIKRM-36
Copy link
Contributor

Pull Request Format

PR Title

Issue #595 : links on the pop-up to Terms of Service and Privacy Policy do not work - solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This PR modifies the popup component by replacing the placeholder # in the anchor tags with direct links to the Privacy Policy and Terms of Service. This enhancement improves user experience by providing easy access to important legal documents, ensuring users can review our policies directly from the popup interface.

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

terms.html page did not exist so i have made a blank template , and made the link to point to it ...
Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 10:22am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @KAUSHIKRM-36! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit fe5ebd2
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6714d9ce929edb0008cfc943
😎 Deploy Preview https://deploy-preview-599--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KAUSHIKRM-36
Copy link
Contributor Author

@swaraj-das please review the PR

Copy link
Contributor Author

@KAUSHIKRM-36 KAUSHIKRM-36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have rechecked the changes , please approve this PR @swaraj-das

@swaraj-das swaraj-das merged commit 1fd7efa into swaraj-das:main Oct 20, 2024
5 of 6 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

@KAUSHIKRM-36 KAUSHIKRM-36 deleted the Bug/issue#595 branch October 20, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants