Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made email & phone no launchable on clicking link in footer #597

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

Adarsh-Chaubey03
Copy link
Contributor

Issue #589 : [BUG] Footer email and phone no aren't clickable and hence not launching gmail on clicking (solved)

Type of PR

  • Bug fix

Description

Made email & phone no launchable on clicking link in footer

Screenshots / Videos (if applicable)

  • updated footer
    Screenshot 2024-10-20 095210
  • launchable email
    Screenshot 2024-10-20 095237
  • launchable phone no.
    Screenshot 2024-10-20 095252

Checklist

  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

@swaraj-das please review my pr

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 4:28am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Adarsh-Chaubey03! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 6598dfa
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/671486e99619280008595e36
😎 Deploy Preview https://deploy-preview-597--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@swaraj-das swaraj-das merged commit fbbe5dc into swaraj-das:main Oct 20, 2024
6 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants